[diff_drive] Remove unused parameter and add simple validation #abi-breaking (backport #958) #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reaking (ros-controls#958) (cherry picked from commit 2705ca8) # Conflicts: # diff_drive_controller/test/test_diff_drive_controller.cpp
|
If the CI is happy we could merge this. The CI was clearly unhappy on the humble backport |
github-actions
bot
requested review from
aprotyas,
arne48,
bijoua29,
bmagyar,
destogl,
livanov93 and
VX792
we didn't backport this to humble anyways. You tried fixing the original backport to iron. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iron #1056 +/- ##
==========================================
- Coverage 47.46% 47.12% -0.35%
==========================================
Files 40 40
Lines 3685 3682 -3
Branches 1758 1756 -2
==========================================
- Hits 1749 1735 -14
- Misses 722 735 +13
+ Partials 1214 1212 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Too many parallel universes to handle :D |
bmagyar
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1:1 backport of #958. @bmagyar why do you think we have to do something different as you have changed with #1008?